AP_Scripting: fixed use after free bug

found with valgrind
ArduPilot · Dec 29, 2023 · 6fb99d6 · 6fb99d6
1 parent 1d0fc4e
commit 6fb99d6
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/libraries/AP_Scripting/lua_scripts.cpp b/libraries/AP_Scripting/lua_scripts.cpp
@@ -402,19 +402,18 @@ void lua_scripts::remove_script(lua_State *L, script_info *script) {
         }
     }
 
+    {
+        // Remove from running checksum
+        WITH_SEMAPHORE(crc_sem);
+        running_checksum ^= script->crc;
+    }
+
     if (L != nullptr) {
         // state could be null if we are force killing all scripts
         luaL_unref(L, LUA_REGISTRYINDEX, script->lua_ref);
     }
     _heap.deallocate(script->name);
     _heap.deallocate(script);
-
-    {
-        // Remove from running checksum
-        WITH_SEMAPHORE(crc_sem);
-        running_checksum ^= script->crc;
-    }
-
 }
 
 void lua_scripts::reschedule_script(script_info *script) {