Scripting: better per script memory tracking #23647
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves away from using the provided lua memory tracking and "manualy" tracking via our alloc function. This means we can track the total allocation per run rather than just the memory change. Just tracking the change masks issues because garbage collection can happen during a script run. This change also allows us to track per script memory.
This adds lots of
AP_SCRIPTING_CHECKS
defines to check the memory count matches the lua one. It turns outAP_SCRIPTING_CHECKS
are always enabled....I have not tested the checks still all pass for every combination of script errors and garbage collection. Also not tested the repl.