Add EchoPilot AI board id #23653
Closed
Add EchoPilot AI board id #23653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
approved these changes
Nov 9, 2023
tridge
requested changes
Nov 9, 2023
| @@ -261,6 +261,7 @@ AP_HW_CUBEORANGE_PERIPH 1400 | |||
| AP_HW_CUBEBLACK_PERIPH 1401 | |||
| AP_HW_PIXRACER_PERIPH 1402 | |||
| AP_HW_SWBOOMBOARD_PERIPH 1403 | |||
| AP_HW_EchoPilotAI 1404 | |||
There was a problem hiding this comment.
apologies, this is failing CI with:
ValueError: Duplicate ID 1404 in file for (AP_HW_EchoPilotAI) and (AP_HW_VIMDRONES_FLOW)
Hwurzburg
requested changes
Nov 9, 2023
| @@ -261,6 +261,7 @@ AP_HW_CUBEORANGE_PERIPH 1400 | |||
| AP_HW_CUBEBLACK_PERIPH 1401 | |||
| AP_HW_PIXRACER_PERIPH 1402 | |||
| AP_HW_SWBOOMBOARD_PERIPH 1403 | |||
| AP_HW_EchoPilotAI 1404 | |||
|
It would be good to also modify the commit message to start with "Tools:" or "Bootloader:". To be clear, I meant the commit message, no the PR title. |
|
@climr please open a fresh pull request if you still want to reserve a board ID. We'll try to be a bit more diligent next time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.