Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_HAL_Linux: delete unused header files #24217

Merged
merged 1 commit into from
Jun 16, 2024
Merged

AP_HAL_Linux: delete unused header files #24217

merged 1 commit into from
Jun 16, 2024

Conversation

xianglunkai
Copy link
Contributor

clean some unused header files.

magicrub
magicrub requested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@magicrub magicrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need GCS_MAVLink/GCS.h but the other two can be removed. To test, use:

./waf configure --board disco
./waf plane

@xianglunkai
Copy link
Contributor Author

@magicrub
Txs! This is my mistake!
I don't want to see GCS related files appear in HAL, although it facilitates debugging.
Do we reconsider the architecture of the system?

@peterbarker peterbarker force-pushed the clean-headers-for-HAL branch from 4115af4 to 8f2ef38 Compare June 5, 2024 01:23
@peterbarker peterbarker merged commit 5b05a17 into ArduPilot:master Jun 16, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicrub magicrub magicrub requested changes

Assignees
No one assigned
Labels
MergeOnCIPass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xianglunkai @magicrub @peterbarker