-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Parachute: Optional (CHUTE_OPTIONS:1) disarm before parachute release #26129
AP_Parachute: Optional (CHUTE_OPTIONS:1) disarm before parachute release #26129
Conversation
We have a option to enable safety switch on disarm, if that was set disarm would cause safety to come on which could in-turn inhibit your parachute release servo. I'm not really sure how we can overcome that. It maybe such a edge case that is does not matter. Of course it only affects those methods that don't currently disarm. |
Hi @IamPete1 . Please write a set of parameters and actions that will lead to this. I have tested many cases and cannot inhibit the parachute servo with the safety buttons. |
0616b53
to
7239f17
Compare
@IamPete1 we currently always disarm on release, so this is adding an option to not do that. The exact order is likely not important as setting the PWM for a server isn't instantaneous anyway |
I think this is good, marked for dev call topic for discussion |
@Hwurzburg for docs, we need to note that BRD_SAFETY_MASK needs to be setup to allow chute servo when disarmed if you have the option to set safety on when you disarm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note that there is a change in behavior in plane battery fail-safe case where we would previously not disarm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a split
We should fix the commit message. |
7239f17
to
20fe981
Compare
I split the commits into subsystems and rebased |
Many thanks |
Based on discussion of PR #25570 and #25562.
Disarm before parachute release to avoid parachute tangling if parameter CHUTE_OPTIONS:1 = 0.