Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Parachute: Optional (CHUTE_OPTIONS:1) disarm before parachute release #26129

Merged

Conversation

python36
Copy link
Contributor

@python36 python36 commented Feb 2, 2024

Based on discussion of PR #25570 and #25562.

Disarm before parachute release to avoid parachute tangling if parameter CHUTE_OPTIONS:1 = 0.

@python36 python36 changed the title Optional (CHUTE_OPTIONS:1) disarm debore parachute release AP_Parachute: Optional (CHUTE_OPTIONS:1) disarm debore parachute release Feb 2, 2024
@python36 python36 changed the title AP_Parachute: Optional (CHUTE_OPTIONS:1) disarm debore parachute release AP_Parachute: Optional (CHUTE_OPTIONS:1) disarm before parachute release Feb 2, 2024
@IamPete1
Copy link
Member

IamPete1 commented Feb 2, 2024

We have a option to enable safety switch on disarm, if that was set disarm would cause safety to come on which could in-turn inhibit your parachute release servo.

I'm not really sure how we can overcome that. It maybe such a edge case that is does not matter. Of course it only affects those methods that don't currently disarm.

@python36
Copy link
Contributor Author

Hi @IamPete1 . Please write a set of parameters and actions that will lead to this. I have tested many cases and cannot inhibit the parachute servo with the safety buttons.

@tridge tridge force-pushed the ap_parachute_release_disarm_opt branch from 0616b53 to 7239f17 Compare April 6, 2024 08:15
@tridge
Copy link
Contributor

tridge commented Apr 6, 2024

if that was set disarm would cause safety to come on which could in-turn inhibit your parachute release servo.

@IamPete1 we currently always disarm on release, so this is adding an option to not do that. The exact order is likely not important as setting the PWM for a server isn't instantaneous anyway

@tridge
Copy link
Contributor

tridge commented Apr 6, 2024

I think this is good, marked for dev call topic for discussion

@tridge tridge added the WikiNeeded needs wiki update label Apr 8, 2024
@tridge
Copy link
Contributor

tridge commented Apr 8, 2024

@Hwurzburg for docs, we need to note that BRD_SAFETY_MASK needs to be setup to allow chute servo when disarmed if you have the option to set safety on when you disarm

Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that there is a change in behavior in plane battery fail-safe case where we would previously not disarm.

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a split

@rmackay9
Copy link
Contributor

rmackay9 commented Apr 8, 2024

We should fix the commit message.

@tridge tridge force-pushed the ap_parachute_release_disarm_opt branch from 7239f17 to 20fe981 Compare April 8, 2024 23:18
@tridge
Copy link
Contributor

tridge commented Apr 8, 2024

I split the commits into subsystems and rebased

@peterbarker peterbarker merged commit a83c29c into ArduPilot:master Apr 10, 2024
91 checks passed
@python36
Copy link
Contributor Author

Many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants