topotek gimbal driver #26244
topotek gimbal driver #26244
Conversation
|
Hi @laozhou-fujian, It's really great to see this! The code looks mostly pretty good but I will add review comments in the coming days to provide some corrections. I suspect that other developers may also chime in with suggestions. Thanks! |
|
Okay, thank you |
|
Hello, what are the requirements? |
|
Hi @laozhou-fujian, Thanks again for this contribution. I've rebased on master and added a commit with some formatting changes here https://github.com/rmackay9/rmackay9-ardupilot/commits/topotek-gimbal/ If you're happy with them perhaps you could pull them into your branch and re-push? By the way, we recommend doing your development on a new branch instead of using master. I'm not sure how familiar you are with git but if you use a new branch I think you'll find it will be easier to rebase. I'll mark this for review at the next development call which is Tuesday at 8am Japan time. I'm sure other developers will have feedback. My main concern after looking at the code is that it's big and consumes a fair bit of flash. I hope other developers will have ideas for shrinking the size. |
|
Also if you wanted to send me one of the gimbals I could help with testing which could help it get merged more quickly. Any version is fine, no need to be brand-new or anything. Smaller is better. This is not a requirement though of course! |
|
Thank you, I will make the changes as you requested. May I know where your address is so I can send the gimbal to you? |
…, and the functionality to send commands to stop zoom and stop image size changes twice has been added.
Ardupilot add topotek gimbal
|
Hi @laozhou-fujian, Thanks very much! I've emailed you my address from rmackay9 at yahoo.com |
Due to a large number of our company's clients using the topotek gimbal on the ardupilot platform, we have developed gimbal and camera drivers.
official website of the company: https://www.topotek.com/