AP_Filesystem: guarantee load_file() data is null-terminated #26310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpwrules
force-pushed
the
file-null-termination
branch
from
2c98217 to
c0a88f6
Compare
|
Whoops, forgot that |
tridge
approved these changes
May 3, 2024
Also remove the redundant insertion of the null terminator.
Improves safety of use and clarity of users. Termination is not included in the reported size to avoid changing user behavior or misrepresenting the file contents.
tridge
force-pushed
the
file-null-termination
branch
from
c0a88f6 to
1f347ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the same safety guarantee and user experience improvement as
AP_ROMFS::find_decompress.Also clean up the users and the comments and clarify AP_ROMFS's usage too.
Tested on CubeOrange. Flashing its own bootloader works and so does the LASTLOG.TXT, which exercises the changed code.