GCS_MAVLink: dont send timesync or on active channels for high latency links #26385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Mar 5, 2024
peterbarker
requested changes
Mar 5, 2024
stephendade
force-pushed
the
hlextrafilter
branch
2 times, most recently
from
af6c3e3 to
116b51f
Compare
peterbarker
requested changes
Mar 5, 2024
stephendade
force-pushed
the
hlextrafilter
branch
3 times, most recently
from
b02ab94 to
b9fc300
Compare
stephendade
force-pushed
the
hlextrafilter
branch
from
b9fc300 to
b9c1a1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
TIMESYNCandNAMED_VALUE_FLOATMAVLink messages are sent over High Latency MAVLink ports. They should not be sent.This PR prevents them from being sent.
Note I'm using the
send_to_active_channels()function inlibraries/GCS_MAVLink/GCS.cppto filter out theNAMED_VALUE_FLOATmessages, assend_named_float()doesn't allow me to select which channels to send/not send.