fix logging feature extract #26421
Merged
fix logging feature extract #26421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hwurzburg
force-pushed
the
fix_logger_feature
branch
3 times, most recently
from
d79a865 to
7b7aec0
Compare
peterbarker
approved these changes
Mar 7, 2024
peterbarker
force-pushed
the
fix_logger_feature
branch
from
7b7aec0 to
685a684
Compare
|
Darn. I wonder if we can add a test for this in CI somehow. I've fixed the commit message and marked as MergeOnCIPass |
maybe check all features are present in a SITL build? Or have a whitelist of symbols not expected to be present? |
|
Do we need to backport this to have it apply to 4.5? I suspect not but want to be sure.. |
92 tasks
|
this is(was) a build server wiki issue not code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently custom builds have no logging enabled by default....this should correct that, as well as correcting the feature lists for ALLthe boards which currently show no logging is included .....tested on omnibusf4pro build...logging now in included features list