Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Freestyle SITL #26491

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

MichelleRos
Copy link
Contributor

@MichelleRos MichelleRos commented Mar 12, 2024

Adds an FPV Freestyle type of quad (i.e. small and very low hover throttle, thus fast).

This one's max speed is slightly higher than real quads, probably because SITL doesn't seem to do battery sag (which is a lot on these copters) and because SITL doesn't have much noise, so all four motors can sit at nearly max throttle.

Currently a draft as I still want to improve some of the tuning.
Finished tuning so it's working well enough.

@MichelleRos MichelleRos force-pushed the pr/add-freestyle-sitl branch from 1256c3a to 2184b3f Compare March 23, 2024 01:32
@MichelleRos MichelleRos marked this pull request as ready for review March 23, 2024 01:35
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tuning on this frame isn't good enough to allow the FlyEachFrame test to pass.

Should be able to run that test locally a few times to have it fail (it's the sort of thing that can flap).

... I've no idea why the autotest suite decided it was a good idea to stack-trace the process in the test output here, that's weird.

@tridge tridge force-pushed the pr/add-freestyle-sitl branch from 2184b3f to 76e1dc4 Compare April 17, 2024 08:04
@MichelleRos MichelleRos force-pushed the pr/add-freestyle-sitl branch from 76e1dc4 to f31fbcc Compare April 17, 2024 14:47
@MichelleRos MichelleRos force-pushed the pr/add-freestyle-sitl branch from f31fbcc to db12988 Compare April 17, 2024 15:24
@MichelleRos
Copy link
Contributor Author

Turns out that autotest wasn't loading the frame-specific defaults (eg freestyle.param) when using json frames, so autotest was using the default tune, which is very unflyable on this copter.

Rebased on master (with #26838) and then on top of #26839, and ran the FlyEachFrame test twice to check that it's now passing that test locally.

Thank you @peterbarker for figuring out the fix.

@peterbarker peterbarker merged commit 9d470d4 into ArduPilot:master Apr 17, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants