Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: smooth plane roll to multicopter roll in position 1 #26592

Closed
wants to merge 1 commit into from

Conversation

magate
Copy link
Contributor

@magate magate commented Mar 23, 2024

Context

Currently there is a discontinuity in position 1 when we use multicopter roll for the plane controller. This can be most easily seen when overshooting the path and the plan controller is coming back on course calculating an intercept. We could be right of course and commanding right roll to smoothly line up with the desired ground track. The multicopter controller ends up calculating a left roll for left lateral acceleration to get back on the course (since we are right of course).

In normal operations this does not cause too many issues.

NB: there is still some discontinuity I cannot track down.

Waypoints

position1.txt

Current behavior

current_behavior.BIN.txt
image

New behavior

new_behavior.BIN.txt
image

@magate
Copy link
Contributor Author

magate commented Apr 11, 2024

Tested this today and it was worse than the current behavior.

@magate magate closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant