Plane: smooth plane roll to multicopter roll in position 1 #26592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently there is a discontinuity in position 1 when we use multicopter roll for the plane controller. This can be most easily seen when overshooting the path and the plan controller is coming back on course calculating an intercept. We could be right of course and commanding right roll to smoothly line up with the desired ground track. The multicopter controller ends up calculating a left roll for left lateral acceleration to get back on the course (since we are right of course).
In normal operations this does not cause too many issues.
NB: there is still some discontinuity I cannot track down.
Waypoints
position1.txt
Current behavior
current_behavior.BIN.txt
New behavior
new_behavior.BIN.txt