AP_Misison: take location in landing sequence functions, copter passes stopping point. #26633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ump_to_landing_sequence`
….get_landing_sequence_start() > 0`
…it to `get_landing_sequence_start`
…anding_sequence`, `jump_to_abort_landing_sequence`, and `is_best_land_sequence`, add helpers for scripting
IamPete1
force-pushed
the
mission_landing_takes_loc
branch
from
2cfe839 to
acb32cb
Compare
rmackay9
approved these changes
Apr 2, 2024
tridge
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract from #26383, this reworks to pass a location into the various landing mission methods. This is important for copter which may be closer to point A at the current time, but is going fast, so once it has stopped to head to A would have been better to head to point B.
Unfortunately there are scripting bindings for the
jump_to_landing_sequenceandjump_to_abort_landing_sequenceso it would be a breaking change, this adds helpers in mission to fill in the location. We could also: