AP_ESC_Telem:make logged ESC id match the output to which its attached #26857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Apr 22, 2024
| @@ -527,7 +527,7 @@ void AP_ESC_Telem::update() | |||
| const struct log_Esc pkt{ | |||
| LOG_PACKET_HEADER_INIT(uint8_t(LOG_ESC_MSG)), | |||
| time_us : now_us64, | |||
| instance : i, | |||
| instance : _i, //makes logged instance agree to output that ESC is attached | |||
There was a problem hiding this comment.
probably no need for the intermediate "_i" variable. This line could be changed to: "instance : i+1" instead.
There's a comment a few lines up that says "id starts from 0" which should be updated.
There was a problem hiding this comment.
tried that first and it failed to compile
|
We should discuss whether we want to make the logging instance consistent with the user parameters (which is what I think this is trying to do). Normally the logging instance starts from 0. As an alternative maybe adding a servo_out field would be helpful? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first time using ESC telem logs the ESC log id index being one off from its output attachment was immediately odd
NFC change