Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #26888

Closed
wants to merge 1 commit into from
Closed

Update README.md #26888

wants to merge 1 commit into from

Conversation

okok125
Copy link

@okok125 okok125 commented Apr 25, 2024

I added the motor output mapping in the readme file. Convenient for users to install and connect. Thank you, please help me see if this is correct.

I added the motor output mapping in the readme file. Convenient for users to install and connect. Thank you, please help me see if this is correct.
@Hwurzburg
Copy link
Collaborator

Motor numbers(or servo functions) are mapped to outputs by SERVOx_FUNCTIONS and are determined by the user params.
Not sure why or what you think this accomplishes and is most certainly incorrect for most users
if you are saying the the board output numbers do not match the hwdef connections to the cpu then we need to fix the hwdef and need SDModel to verify and approve

@rmackay9
Copy link
Contributor

Hi @okok125,

Thanks for this. Could you update the commit message (and to be clear I mean the commit itself, not the PR) to be something like, "ChibiOS: add motor output to SDMODELH7V1 README"

Sorry to be nitpicky but we like to have the subsystem prefixed and clear descriptions to ease backporting

@rmackay9
Copy link
Contributor

rmackay9 commented Apr 25, 2024

@Hwurzburg

My guess is that he's saying the board's Mx labels don't map to the SERVOx parameters as a user might assume which seems terrible!

image

@Hwurzburg
Copy link
Collaborator

that would require verification from SDModel, a schematic, or dev verification with a board (I don't have one, I have the V2) in order to approve this in my opinion

@okok125
Copy link
Author

okok125 commented Apr 26, 2024

There is currently no problem with the firmware of my SDMODEL H7V1, and I have no problem using it. I just want to remind users. When she uses Ardupilot, the motor wiring does not use the BF motor code. She needs to change the MP internal SERVO OUT to the sequence of 4,1,2,3 so that it can fly normally.
I refer to the documents here and have actually verified that the motor output is also mapped in this way.
https://ardupilot.org/copter/docs/common-holybro-kakuteh7.html

@okok125 okok125 closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants