Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add MFT-SEMA100 board #26905

Closed
wants to merge 0 commits into from
Closed

add MFT-SEMA100 board #26905

wants to merge 0 commits into from

Conversation

EternAlmox
Copy link
Contributor

No description provided.

@EternAlmox
Copy link
Contributor Author

Test Setup
Board

tridge
tridge requested changes Apr 27, 2024
View reviewed changes
libraries/AP_HAL_ChibiOS/hwdef/MFT-SEMA100/hwdef-bl.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/MFT-SEMA100/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/MFT-SEMA100/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/MFT-SEMA100/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/MFT-SEMA100/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/MFT-SEMA100/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/MFT-SEMA100/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/MFT-SEMA100/hwdef.dat Outdated Show resolved Hide resolved
@EternAlmox EternAlmox requested a review from tridge April 27, 2024 23:54
tridge
tridge previously requested changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting closer, thanks.
please add a README.md with a description of the board in the hwdef directory, and an image. @Hwurzburg uses this to help write documentation

@Hwurzburg
Copy link
Collaborator

look at this PR for an example of readme.md, images, info required for documentation: (xls doc not required) #26854
also how commits are organized
it is usually a good idea to make the board_types.txt a separate PR to reserve the board id since it might be taken while this PR gets finalized and documentation provided....avoids having thee change your board id at the last minute when this gets about to be merged

@Hwurzburg Hwurzburg self-requested a review April 28, 2024 22:05
@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Apr 28, 2024
@Hwurzburg Hwurzburg changed the title AP_Bootloader: reserve ID for MFT-SEMA100 add MFT-SEMA100 board Apr 28, 2024
@Hwurzburg
Copy link
Collaborator

@EternAlmox will review docs tomorrow...having hospital procedure done today

@tridge tridge dismissed their stale review May 1, 2024 22:53

fixed

@Hwurzburg
Copy link
Collaborator

Started my review, but before I can complete it I need the mapping from the marked TXn/RXn pins on the board to the CPU's uarts...the docs are inconsistent....please provide a list and then I can finish the review

also, the current definition leaves no UART with full DMA on TX and RX so some RC protocols will not be supported (CRSF,ELRS,etc.)...and the second GPS does not have DMA, requiring ALL GPSes to be restricted to 115K, this needs to be changed

@EternAlmox EternAlmox closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hwurzburg Hwurzburg Hwurzburg requested changes

@tridge tridge tridge left review comments

Assignees
No one assigned
Labels
WikiNeeded needs wiki update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EternAlmox @Hwurzburg @tridge