Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rover: Use common variables #26964

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

muramura
Copy link
Contributor

@muramura muramura commented May 3, 2024

Common variables G and G2 are used.
G and G2 are used directly.

Mixed in the same file.
I think it would be better to unify common variables.

Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but vehicle maintainer has to approve

@IamPete1
Copy link
Member

Looks good, but does cost a little flash, MatekF405:

Binary Name      Text [B]       Data [B]     BSS (B)      Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  -------------  -----------  -----------  ----------------------------  -------------------------
ardusub          0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      187812
antennatracker   0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      343888
arducopter-heli  0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                       82464
ardurover        48 (+0.0059%)  0 (0.0000%)  0 (0.0000%)  48 (+0.0059%)                                    174268
blimp            0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      325092
arduplane        0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                       49384
arducopter       0 (0.0000%)    0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                       93632

@tridge tridge merged commit f7cc7ee into ArduPilot:master Jun 10, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants