Correct Sub boot problem related to default parameters #27013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parameters don't exist for defaulting, so config error loop is entered. The config error loop also isn't working well this early in the boot, so the board is not perfectly informative. Config Error: param deflt fail:BARO_PROBE_EXT no link Config Error: param deflt fail:BARO_PROBE_EXT no link no link Config Error: param deflt fail:BARO_PROBE_EXT no link
the more-than-trivial #if is needed elsewhere, so create an explicit name for it
tridge
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defaults table references parameters that might not exist.
This dumps us into the config error loop whenever that happens.
The config error loop may not always be particularly useful this early in the boot as there's a lot of uninitialised objects floating around, leading to nullptr derefs (at least on Copter, and this board seems to act as if something along those lines is happening)