Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HIL_GPS to be compiled out #27122

Merged

Conversation

peterbarker
Copy link
Contributor

None of MAVProxy, MissionPlanner or QGC send this message.

Added defines around this code so it can be compiled out.

Can emit

###### Enabling MAV_MSG_HIL_GPS(AP_MAVLINK_MSG_HIL_GPS_ENABLED) on copter costs -320 bytes
###### Enabling MAV_MSG_HIL_GPS(AP_MAVLINK_MSG_HIL_GPS_ENABLED) on plane costs -320 bytes
###### Enabling MAV_MSG_HIL_GPS(AP_MAVLINK_MSG_HIL_GPS_ENABLED) on rover costs -320 bytes
###### Enabling MAV_MSG_HIL_GPS(AP_MAVLINK_MSG_HIL_GPS_ENABLED) on antennatracker costs -320 bytes
###### Enabling MAV_MSG_HIL_GPS(AP_MAVLINK_MSG_HIL_GPS_ENABLED) on sub costs -320 bytes
###### Enabling MAV_MSG_HIL_GPS(AP_MAVLINK_MSG_HIL_GPS_ENABLED) on blimp costs -320 bytes

(I've added a deprecation warning since then)

@peterbarker peterbarker force-pushed the pr/allow-hil_gps-to-be-compiled-out branch from 767a9e3 to c761aae Compare May 22, 2024 07:19
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm also happy to remove completely

// handling of HIL_GPS is slated to be removed; GPS_INPUT can be used
// in its place
#ifndef AP_MAVLINK_MSG_HIL_GPS_ENABLED
#define AP_MAVLINK_MSG_HIL_GPS_ENABLED 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets save the flash and off by default

@tridge tridge removed the DevCallEU label May 22, 2024
@peterbarker peterbarker force-pushed the pr/allow-hil_gps-to-be-compiled-out branch from c761aae to b82c939 Compare May 22, 2024 08:40
@tridge tridge merged commit 7194c6e into ArduPilot:master May 22, 2024
91 checks passed
@peterbarker peterbarker deleted the pr/allow-hil_gps-to-be-compiled-out branch May 23, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants