Filter: added test of phase lag vs attenuation #27164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess if you were to interpolate the crossing point it would fix the stepping. |
tridge
force-pushed
the
pr-phase-lag-vs-attenuation
branch
from
2845d71 to
c876c59
Compare
|
Fix here: IamPete1@25ccdb3
We do pick up some funny stuff at 0 attenuation because we don't deal with the phase wrap correctly, moving to floating point math means we get a phase of about 360 and about 0 so the averaging means we get some value in between (eg.180 not 0). To elaborate slight more on the issue, because the noise frequency of 50Hz is a exact multiple of the 2000Hz sample rate we get the samples happening at the same point in the sine every time. This means the error in the zero crossing caculation does not average out. |
IamPete1
force-pushed
the
pr-phase-lag-vs-attenuation
branch
from
c876c59 to
68e35cd
Compare
tridge
force-pushed
the
pr-phase-lag-vs-attenuation
branch
from
68e35cd to
169bac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was for a single notch set at 60Hz with bandwidth of 60Hz. Source frequency was 50Hz, and the test frequency varies for the 5 graphs from 10Hz to 50Hz.