Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITL: delete unnecessary settings #27214

Closed

Conversation

muramura
Copy link
Contributor

@muramura muramura commented Jun 1, 2024

Since the elements are being cleared, the subsequent zero settings are unnecessary.

Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is SITL space, so we don't really care about micro optimisation.
I would say in this case that the original author explicitly write this as it should be important to remember. This shouldn't have any impact on the code, so I will keep the explicit version

@khancyr
Copy link
Contributor

khancyr commented Jun 3, 2024

Thanks anyway. I will close this

@khancyr khancyr closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants