Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_AHRS: clarify frame of get_location_from_origin_offset #27259

Conversation

peterbarker
Copy link
Contributor

No description provided.

... by renaming it get_location_from_origin_offset_NED
... by renaming it get_location_from_origin_offset_NED
@@ -3536,7 +3536,7 @@ bool AP_AHRS::get_velocity_NED(Vector3f &vec) const

// return location corresponding to vector relative to the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing comment seems wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at least confusing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for less-confusing words welcome :-)

Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we really need these helpers. Looks like one is not used at all and the other is used in one place.

I tend to think we should just remove them both....

@peterbarker
Copy link
Contributor Author

I'm not sure we really need these helpers. Looks like one is not used at all and the other is used in one place.

I tend to think we should just remove them both....

Well, I was just adding a new user :-)

These can replace the constructor Location(Vector3f, AltFrame) - which can't actually tell you that origin isn't set now and will give you something very close to 0,0....

@peterbarker peterbarker merged commit 72fa6aa into ArduPilot:master Jun 11, 2024
92 checks passed
@peterbarker peterbarker deleted the pr/rename-get_location_from_origin_offset branch June 13, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants