AC_Autotune: Clean up Multi Variables and non functional changes #27370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
20240624_Autotune_Clean_Up
branch
from
185332a to
62b61bb
Compare
peterbarker
reviewed
Jun 25, 2024
lthall
force-pushed
the
20240624_Autotune_Clean_Up
branch
from
62b61bb to
36c3f3a
Compare
lthall
force-pushed
the
20240624_Autotune_Clean_Up
branch
from
36c3f3a to
17c9baf
Compare
rmackay9
reviewed
Jul 23, 2024
| float start_angle; // start angle | ||
| float start_rate; // start rate - parent and multi | ||
| float rate_max; // maximum rate variable - parent and multi |
There was a problem hiding this comment.
somewhat surprisingly AC_AutoTune_Heli also defines a "rate_max" variable but it is a parameter. I'm slightly surprised that the compiler didn't catch this "shadowing" but in any case it's good to get rid of it.
I think @bnsgeyer should confirm that Heli autotune seems to work OK
rmackay9
reviewed
Jul 24, 2024
lthall
force-pushed
the
20240624_Autotune_Clean_Up
branch
from
17c9baf to
04a0bd0
Compare
rmackay9
approved these changes
Jul 26, 2024
lthall
added a commit
to lthall/Leonard_ardupilot
that referenced
this pull request
Aug 6, 2024
peterbarker
pushed a commit
that referenced
this pull request
Aug 6, 2024
tpwrules
added a commit
to tpwrules/ardupilot
that referenced
this pull request
Dec 4, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in a dangerously low value being calculated and the vehicle being unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
tpwrules
added a commit
to tpwrules/ardupilot
that referenced
this pull request
Dec 4, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
rmackay9
pushed a commit
that referenced
this pull request
Dec 5, 2024
Issue introduced in #27370 and partially fixed in #27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
andyp1per
pushed a commit
to andyp1per/ardupilot
that referenced
this pull request
Dec 7, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
andyp1per
pushed a commit
to andyp1per/ardupilot
that referenced
this pull request
Dec 7, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
tridge
pushed a commit
to tridge/ardupilot
that referenced
this pull request
Dec 11, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
tridge
pushed a commit
that referenced
this pull request
Dec 12, 2024
Issue introduced in #27370 and partially fixed in #27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
Yury-MonZon
pushed a commit
to Yury-MonZon/ardupilot
that referenced
this pull request
Dec 12, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
Yury-MonZon
pushed a commit
to Yury-MonZon/ardupilot
that referenced
this pull request
Dec 12, 2024
Issue introduced in ArduPilot#27370 and partially fixed in ArduPilot#27762, though evidently not properly tested. Failing to track the maximum can result in dangerously low values being calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable. Make the variable a reference so that the maximum value is preserved between function calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have moved the multi only variable declaration variables into the AC_AutoTune_Multi.h.
I removed the "f" from the floats.
I simplified a couple functions.
All these changes should be non-functional.
I am a little disgusted by some of the structures that I made here. This still has some work to do before it could be considered "clean".