Copter: avoid nullptr deref in config_error_loop #27912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we may enter the config_error_loop before we call Copter's methods which allocate the wpnav object. We send mavlink messages in the config error loop, one of which calls this method - so we end up with a nullptr dereference. We might be able to find a way to stop sending this message in the config error loop, but that's likely to take some time to do....
rmackay9
approved these changes
Aug 27, 2024
tridge
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we may neter the config_error_loop before we cann Copter's methods which allocate the wpnav object.
We send mavlink messages in the config error loop, one of which calls this method - so we end up with a nullptr dereference.
We might be able to find a way to stop sending this message in the config error loop, but that's likely to take some time to do....