-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Camera/AP_Mount/GCS_MAVLink: Siyi implements camera-thermal-range #27915
Conversation
4f4322d
to
a8042d7
Compare
This has been updated inline with discussion on the upstream mavlink PR mavlink/mavlink#2145 |
a8042d7
to
2ecd883
Compare
2ecd883
to
910c329
Compare
I've updated this to use the final CAMERA_THERMAL_RANGE mavlink message definition and also hidden the feature behind a define Currently the new message is only sent if requested by the GCS (e.g. not sent by default) |
910c329
to
a1ef878
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM past these
feature size info
|
3ce4c4e
to
549bbcb
Compare
549bbcb
to
7d4971d
Compare
PeterB's requests implemented, txs for the review!
This PR adds support for sending the min and max temperatures and their XY positions in the live video stream to the ground station when using Siyi ZT6 and ZT30 cameras. We can add support for ViewPro and Topotek cameras in a follow-up PRs.
This is useful for search & rescue and firefighting applications because the ground station can overlay a rectangle over the hotspot along with its temperature.
This PR relies on this mavlink PR ArduPilot/mavlink#369 (and the equivalent upstream PR mavlink/mavlink#2145).
It is also built on PR #27890 and PR #27911 so those should be merged first.
This has been lightly tested on real-hardware (a CubeOrange + Siyi ZT6) and below is a screen shot showing the temperature jump when I moved in front of the camera although please note that the test used named value pairs to send the temperatures and positions instead of using the new mavlink message.