Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up includes to avoid nasty include loop #27959

Closed

Conversation

peterbarker
Copy link
Contributor

AP_NavEKF2's LogStructure was including AP_AHRS.h, which can cause some nasty loops.

Change it to use AP_AHRS_config.h, which is all that it needs.

Fix up places which only had AP_NavEKF{2,3}.h because they were getting it transitively from AP_NavEKF2/LogStructure.

@peterbarker
Copy link
Contributor Author

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  0                                                                     
Durandal                            16     *           0       0                 0      8      8
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     -72    *           -72     -72               -80    -80    -72
MatekF405                           -40    *           -56     -48               -56    -48    -48
Pixhawk1-1M-bdshot                  -56                -64     -64               -64    -72    -64
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           -48    *           -56     -56               -56    -48    -56
skyviper-v2450                                         -48                                     

@peterbarker
Copy link
Contributor Author

Closing in favour of https://github.com/ArduPilot/ardupilot/pull/27961/files which combines this with other fixes

@peterbarker peterbarker deleted the pr/navekf2-logstructure branch August 30, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants