Avoid use of AP_Logger.h in library headers

[peterbarker]

this pulls in many more headers, we should avoid using it whereever we can

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
Durandal                            *      *           *       *                 *      *      *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           *       *                 *      *      *
MatekF405                           *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 *      *      *
skyviper-v2450                                         *                                       

[IamPete1]

I would have expected this to be deleted from where ever it is now.

[peterbarker]

Ah, I remember now. We can't move the definition of this into the .cpp file. log_ATRP is included into ArduPlane's log structure:

SCB-WAF: [1166/1206] Compiling ArduPlane/mode.cpp../../ArduPlane/Log.cpp:363:41: error: 'log_ATRP' is not a member of 'AP_AutoTune'
SCB-WAF: ../../ArduPlane/Log.cpp:363:41: error: 'log_ATRP' is not a member of 'AP_AutoTune'  363 |     { LOG_ATRP_MSG, sizeof(AP_AutoTune::log_ATRP),
SCB-WAF:   363 |     { LOG_ATRP_MSG, sizeof(AP_AutoTune::log_ATRP),      |                                         ^~~~~~~~
SCB-WAF:       |                                         ^~~~~~~~compilation terminated due to -Wfatal-errors.

... I discovered that but only half-undid the change :-(

I really think we should look at changing this to a WriteStreaming or similar...

[tridge]

can remove logstructure.h here too, if you remove log_ATRP

[peterbarker]

Yeah, can't do that as that message is included in ArduPlane's LogStructure!

Should probably be a WriteStreaming call instead, but for now I've put it back in the header, where we only need AP_Logger/LogStructure.h, not AP_Logger.h, which is the important change.

[peterbarker]

Still no compiler output changes with this.