-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TBS LUCID Pro #28146
TBS LUCID Pro #28146
Conversation
@andyp1per missing image |
Very draft right now - don't review until its out of draft |
6cfd2cd
to
db56295
Compare
db56295
to
4607310
Compare
Need pinots for GH connectors |
78280ce
to
4d32297
Compare
@andyp1per started looking at this...some questions before a I post a formal review since there are some big disconnects:
|
Need new images. It's the CRSF port.
Need new images.
That's what the schematic says
The DMA mapping works out fine - I checked. You only need to add to DMA_PRIORITY to move things about.
They could be used for dshot. Can't be NODMA because one is the LED which needs DMA. |
put a needsanswer label so this doesnt keep popping up on my radar until new images are provided |
4d32297
to
33f53fa
Compare
Silk screen updated @Hwurzburg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the image has several errors, in addition to my other comments:
- UART5_RX should be UART2_RX
- CAMC should be CAMC/PWM5
33f53fa
to
94b6ddb
Compare
I've asked them to fix
I think this is ok - its a generic picture that covers BF as well which will not have PWM5 |
so we should not tell AP users there is a PWM5?otherwise i think the image should show it |
94b6ddb
to
6792e10
Compare
README is right, hwdef is wrong - I have fixed |
6792e10
to
35bbdfb
Compare
35bbdfb
to
31e971d
Compare
Thanks @Hwurzburg |
this is included in ArduPilot-4.6.0-beta3 |
TBS LUCID PRO