Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBS LUCID Pro #28146

Merged
merged 3 commits into from
Jan 18, 2025
Merged

TBS LUCID Pro #28146

merged 3 commits into from
Jan 18, 2025

Conversation

andyp1per
Copy link
Collaborator

@andyp1per andyp1per commented Sep 18, 2024

TBS LUCID PRO

@Hwurzburg
Copy link
Collaborator

@andyp1per missing image

@andyp1per
Copy link
Collaborator Author

@andyp1per missing image

Very draft right now - don't review until its out of draft

@andyp1per andyp1per marked this pull request as ready for review October 31, 2024 08:11
@andyp1per andyp1per requested a review from Hwurzburg October 31, 2024 08:27
@Hwurzburg
Copy link
Collaborator

Need pinots for GH connectors

@andyp1per andyp1per force-pushed the pr-lucid-pro branch 4 times, most recently from 78280ce to 4d32297 Compare December 24, 2024 16:24
@Hwurzburg
Copy link
Collaborator

@andyp1per started looking at this...some questions before a I post a formal review since there are some big disconnects:

  1. UART1, RCin, is not pinned out in the images...where is it?
  2. Images show UART7/8 which are not defined
  3. is inverted SBus really connected to RX5? just checking since the other UARTs are iffy and hwdef says there is no TX5 but its shown on pinout
  4. if UART1 really is RCin, shouldn't it be in the DMA priority list rather than UART5?
  5. if PWM5/6 are not DShot, shouldn't you tag them NODMA?

@andyp1per
Copy link
Collaborator Author

  • UART1, RCin, is not pinned out in the images...where is it?

Need new images. It's the CRSF port.

  • Images show UART7/8 which are not defined

Need new images.

  • is inverted SBus really connected to RX5? just checking since the other UARTs are iffy and hwdef says there is no TX5 but its shown on pinout

That's what the schematic says

  • if UART1 really is RCin, shouldn't it be in the DMA priority list rather than UART5?

The DMA mapping works out fine - I checked. You only need to add to DMA_PRIORITY to move things about.

  • if PWM5/6 are not DShot, shouldn't you tag them NODMA?

They could be used for dshot. Can't be NODMA because one is the LED which needs DMA.

@Hwurzburg
Copy link
Collaborator

put a needsanswer label so this doesnt keep popping up on my radar until new images are provided

@andyp1per
Copy link
Collaborator Author

Silk screen updated @Hwurzburg

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Jan 13, 2025
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image has several errors, in addition to my other comments:

  • UART5_RX should be UART2_RX
  • CAMC should be CAMC/PWM5

libraries/AP_HAL_ChibiOS/hwdef/TBS_LUCID_PRO/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/TBS_LUCID_PRO/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/TBS_LUCID_PRO/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/TBS_LUCID_PRO/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/TBS_LUCID_PRO/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/TBS_LUCID_PRO/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/TBS_LUCID_PRO/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/TBS_LUCID_PRO/README.md Outdated Show resolved Hide resolved
@andyp1per
Copy link
Collaborator Author

the image has several errors, in addition to my other comments:

* UART5_RX should be UART2_RX

I've asked them to fix

* CAMC should be CAMC/PWM5

I think this is ok - its a generic picture that covers BF as well which will not have PWM5

@andyp1per andyp1per requested a review from Hwurzburg January 15, 2025 18:32
@Hwurzburg
Copy link
Collaborator

so we should not tell AP users there is a PWM5?otherwise i think the image should show it

@andyp1per
Copy link
Collaborator Author

  • UART5_RX should be UART2_RX

README is right, hwdef is wrong - I have fixed

@andyp1per
Copy link
Collaborator Author

Thanks @Hwurzburg

@peterbarker peterbarker merged commit 1965a3e into ArduPilot:master Jan 18, 2025
99 checks passed
@andyp1per andyp1per deleted the pr-lucid-pro branch January 18, 2025 08:32
@rmackay9
Copy link
Contributor

this is included in ArduPilot-4.6.0-beta3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 4.6.0-beta3
Development

Successfully merging this pull request may close these issues.

4 participants