Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mission item logging #28246

Merged
merged 8 commits into from
Oct 1, 2024
Merged

Conversation

peterbarker
Copy link
Contributor

In master we use the "CMD" log message to log both items as they are uploaded and when one of the vehicles actually start to execute the commands. This is weird.

This PR creates a separate log message, MISE which is emitted by the AP_Mission library as it starts the execution of an item. This is a behavioural change; we now log all items, rather than just the ones that the vehicles handle.

I've tested Plane creates the messages appropriately, but need to look at the other affected vehicles.

@rmackay9
Copy link
Contributor

rmackay9 commented Sep 28, 2024

This seems like a good idea to me

Re "Needs Testing", I think we should check how MP handles this in the Log review tool paying particular attention to whether it changes what is shown on the map.

We should also test "Create KML + gpx" which pulls out all the versions of the mission into files
image

@peterbarker
Copy link
Contributor Author

Re "Needs Testing", I think we should check how MP handles this in the Log review tool paying particular attention to whether it changes what is shown on the map.

That view looks entirely reasonable. I can't see any difference between/after this PR.

We should also test "Create KML + gpx" which pulls out all the versions of the mission into files ![image](https://private-user-

That also works fine - but I think that only shows a position tack, doesn't have waypoint information in it? I can't see any difference before/after.

I made the deliberate choice to make the mission upload retain the "CMD" message name, and make the execution message the new MISE.

@tridge tridge merged commit 981c500 into ArduPilot:master Oct 1, 2024
95 checks passed
@peterbarker peterbarker deleted the pr/fix-mission-logging branch October 1, 2024 03:11
@Georacer
Copy link
Contributor

Georacer commented Oct 1, 2024

Yes! The log review gods are please with this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants