-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mission item logging #28246
Fix mission item logging #28246
Conversation
That view looks entirely reasonable. I can't see any difference between/after this PR.
That also works fine - but I think that only shows a position tack, doesn't have waypoint information in it? I can't see any difference before/after. I made the deliberate choice to make the mission upload retain the "CMD" message name, and make the execution message the new MISE. |
Yes! The log review gods are please with this one! |
In master we use the "CMD" log message to log both items as they are uploaded and when one of the vehicles actually start to execute the commands. This is weird.
This PR creates a separate log message,
MISE
which is emitted by the AP_Mission library as it starts the execution of an item. This is a behavioural change; we now log all items, rather than just the ones that the vehicles handle.I've tested Plane creates the messages appropriately, but need to look at the other affected vehicles.