Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:hwdef.dat for betaflightf4 added #28659

Conversation

Srivenkateshwar
Copy link
Contributor

No description provided.

@Hwurzburg
Copy link
Collaborator

Hwurzburg commented Nov 17, 2024

change the directory names to "CrazyF405HD" BetaflightF4 is too generic
I would break out the board type to a separate PR...they can be merged quickly, reserving the bd id while the main PR gets reviewed, and use the CrazyF405HD name for the board there

@Srivenkateshwar Srivenkateshwar force-pushed the add-hwdef.dat-for-beatflightf4-hardware branch from a510f65 to d2871b8 Compare November 17, 2024 13:43
@Srivenkateshwar
Copy link
Contributor Author

Renamed the BetaflightF4 to CrazzyF405 also removed the board id and added that in different PR

@Srivenkateshwar
Copy link
Contributor Author

@Hwurzburg is there anything from my side should be updated?

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a bootloader in Tools/bootloader
Needs to be two commits, one for bootloader titled Tools:add CrazyF405 bootloader
and another for other files titled hwdef: add CrazyF405:

MCU STM32F4xx STM32F405xx

# board ID for firmware load
APJ_BOARD_ID 1177
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
APJ_BOARD_ID 1177
APJ_BOARD_ID AP_HW_CrazyF405

MCU STM32F4xx STM32F405xx

# board ID for firmware load
APJ_BOARD_ID 1177
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
APJ_BOARD_ID 1177
APJ_BOARD_ID AP_HW_CrazyF405

# USART2
PA2 USART2_TX USART2
PA3 USART2_RX USART2

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the RC input

Suggested change
define DEFAULT_SERIAL3_PROTOCOL SerialProtocol_RCIN

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here Serial2_protocol should RCIN right??

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy paste error sorry....right

libraries/AP_HAL_ChibiOS/hwdef/CrazyF405/hwdef.dat Outdated Show resolved Hide resolved
define HAL_LOGGING_DATAFLASH_ENABLED 1

# OSD setup
SPIDEV osd SPI2 DEVID1 OSD_CS MODE0 10*MHZ 10*MHZ
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove, this chip does not exist

|SERIAL0|COMPUTER|USB|
|SERIAL1|RX1/TX1|UART1 ( DMA-enabled)|
|SERIAL2|TX2/RX2|UART2 (ELRS, internal)
|SERIAL6|RX6|UART6 (DMA-disabled)|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|SERIAL6|RX6|UART6 (DMA-disabled)|
|SERIAL5|RX6|UART6 (USER,DMA-disabled)|


## RC Input

RC input is configured on the on-board ELRS on UART2 or through (UART2_RX/UART2_TX) pins. It supports all serial RC protocols.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you disable the ELRS module to allow an external RC on TX2/RX2????


Once the initial firmware is loaded you can update the firmware using
any ArduPilot ground station software. Updates should be done with the
*.apj firmware files.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*.apj firmware files.
\*.apj firmware files.


## PWM Output

The Carzyf405HD AIO has 4 PWM outputs internally connected to its 4-in-1 ESC. The pads for motor output are M1 to M4 on the board. All 4 outputs support bi-directional DShot and DShot, as well as all PWM types. The default configuration is for DShot using the already installed BlueJay firmware.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your hwdef does NOT support bi-directional DShot. it may, but does not now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya ,so i will mention about the DSHOT only

libraries/AP_HAL_ChibiOS/hwdef/CrazyF405/hwdef.dat Outdated Show resolved Hide resolved
@Srivenkateshwar
Copy link
Contributor Author

Srivenkateshwar commented Dec 2, 2024

@Hwurzburg can i updated your changes and rebase this repo to updated changes?? Or do you need me to commit here

@Hwurzburg
Copy link
Collaborator

update this PR by making those changes in your Srivenkateshwar:add-hwdef.dat-for-beatflightf4-hardware branch...they will appear here...

FYI the commit names/grouping are not correct, I could fix for you, but you did not check the box "allow maintainers to update" when you created the pull request....if you give me access to your repo, I can do it for you when all changes have been done

@Srivenkateshwar Srivenkateshwar force-pushed the add-hwdef.dat-for-beatflightf4-hardware branch from d2871b8 to cbfc419 Compare December 4, 2024 15:13
@Srivenkateshwar Srivenkateshwar force-pushed the add-hwdef.dat-for-beatflightf4-hardware branch from cbfc419 to 98f3f59 Compare December 9, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants