Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_InertialSensor: constrain ICM45686 to 800Hz-6.4KHz #28682

Closed
wants to merge 1 commit into from

Conversation

andyp1per
Copy link
Collaborator

Simpler alternative to #27573

@bugobliterator
Copy link
Member

Hi @andyp1per I don't like this way of doing it actually. This PR changes the ODR of the sensor to a seriously low value, which is quite a regression, and changes filter behaviour and possibly have affect on measurement quality as well. I would really like to continue to find a way to get the initial PR in.

@andyp1per
Copy link
Collaborator Author

andyp1per commented Nov 23, 2024

@bugobliterator I changed this so the ODR is unchanged for the settings you are concerned about. To get the other PR in please can you make it this simple - I had to write this PR simply to get straight in my head what your PR is actually trying to do - there are so many non-core changes that its really hard to parse and its the non-core changes that I am really objecting to. The actual change you want should be a matter of a few lines.

Note that I am not doing anything different here to what is happening in the ICM42688 which goes from 1KHz - 8Khz (instead of 800Hz - 6.4KHz) the differences are not that significant. The actual sensor rate is still happening at a very high rate so a lot of the aliasing advantages are still there.

@andyp1per andyp1per closed this Jan 25, 2025
@andyp1per andyp1per deleted the pr-icmv3-rates branch January 25, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants