ardupilotwaf: properly configure double precision tasks #28965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There might be multiple copies of the flags, so remove all of them. Also pull the setup into a helper function to avoid duplicating the logic. On ChibiOS boards, this fixes SITL (which had issues with position quantization) and affects the SBF GPS driver (which was probably fine before but does change slightly).
Use new setup function. Unsure if this affects anything.
andyp1per
approved these changes
Dec 30, 2024
khancyr
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
LGTM, python code is correct.
can probably squash the commit in one.
For testing, you can probably look at target with double enabled and compare if both version produce the same binaries. The second test should be to look at a lib that got double enable and both version produce the same compiled code
tridge
approved these changes
Dec 30, 2024
|
this is included in ArduPilot-4.6.0-beta3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be multiple copies of the flags, so remove all of them. Also pull the setup into a helper function to avoid duplicating the logic. On ChibiOS boards, this fixes SITL (which had issues with position quantization) and affects the SBF GPS driver (which was probably fine before but does change slightly).
Sim on hardware now flies smoothly instead of jittering about all over the place. SBF requires a handful more bytes but I don't think this meaningfully affects the function based on a brief read-through; the important lat/lon casts were already done manually.
Many thanks to tridge for working with me to debug this. Assuming it should be backported so that SBF works as written even if the change in behavior is negligible.