AP_HAL_ChibiOS: Scheduler: clean up expected delay functions #28972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8dabd6c. Setting up expected delays from a non-main thread never worked properly due to the redundant main thread check, and isn't used today.
EXPECT_DELAY_MS was used in direct contravention of the comment so it must be okay. Even when it wasn't and the comment was accurate, expecting a delay off the main thread never worked properly anyway.
|
Won't this cause issues when we erase flash pages? We'll no longer be expecting the long delay that that introduces? |
|
The off-main-thread expectation never worked in the first place, there's no change in behavior here :) |
tridge
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature to expect delays from the main thread never worked (since introduction in #14063 ) and hasn't been used since #20442 . Remove it to gain back some flash and reduce complexity.
Checked that parameter and mission ops still work on Kakute H7 Mini.