LXC: don't set undefine flags (#77)

AshleyYakeley · Jan 13, 2025 · 9063243 · 9063243
1 parent 3e66d99
commit 9063243
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/tool/nixvirt.py b/tool/nixvirt.py
@@ -115,10 +115,17 @@ def _descriptionXML(self,lvobj):
         return lvobj.XMLDesc(flags=2)
     def _undefine(self,lvobj):
         # https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainUndefineFlagsValues
-        # VIR_DOMAIN_UNDEFINE_MANAGED_SAVE
-        # VIR_DOMAIN_UNDEFINE_KEEP_NVRAM
-        # VIR_DOMAIN_UNDEFINE_KEEP_TPM
-        lvobj.undefineFlags(flags=73)
+        match self.session.driver:
+            case "QEMU":
+                # VIR_DOMAIN_UNDEFINE_MANAGED_SAVE
+                # VIR_DOMAIN_UNDEFINE_KEEP_NVRAM
+                # VIR_DOMAIN_UNDEFINE_KEEP_TPM
+                flags=73
+            case "LXC":
+                flags=0  # LXC doesn't support undefine flags
+            case _:
+                flags=73  # best guess, same as QEMU
+        lvobj.undefineFlags(flags=flags)
     def _fixDefinitionETree(self,objid,specDefETree):
         interfaces = specDefETree.xpath("/domain/devices/interface")
         index = 0