Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compositor: Smoothen circle border #175

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MagneFire
Copy link
Member

@MagneFire MagneFire commented Sep 8, 2024

Smoothen borders such that the display blends into the bezel.

This PR is mostly meant as a means to start a discussion on if we want this functionality in the first place 😄

20240908_224045

If we want this we probably also need to think about non-circular displays. Perhaps we can also enable this based on a device property. For instance this feature might make sense on sawfish (because of the huge bezel) but not on smelt which doesn't have a bezel (flat tire).

Smoothen borders such that the display blends into the bezel.

Signed-off-by: Darrel Griët <[email protected]>
@FlorentRevest
Copy link
Member

I originally introduced this for my bass where the screen borders seemed heavily pixelized, this was a cheap trick to make the screen look a bit better than it was :p (this was not about the thickness of the bezels) I still think it adds a nice polish to the AsteroidOS UI but maybe Timo has opinions on this ? At the time, I did not worry about flat tires but it could make sense to add a similar smoothing effect at the level of the flat tire maybe ?

Although it could make sense to compare a few smoothing options, I'd be leaning towards keeping this thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants