Skip to content

Commit

Permalink
Update libwatchfish, use harbour- prefix
Browse files Browse the repository at this point in the history
This changes the libwatchfish submodule to now point at Piggz updated
fork.
Changing to this new fork resolves various compilation issues due to an
incomplete implementation of various dbus services.

Additionally this changes the asteroidsyncserviced, when compiled with
"CONFIG+=starfish" to have "harbour-" prefixed to its name.

The reasoning behind this change, is that Jolla has a requirement for all
applications that are submittted to the offical store have this prefix.
https://harbour.jolla.com/faq#1.1.0
  • Loading branch information
GeoffTearle authored and FlorentRevest committed Mar 9, 2021
1 parent 96126da commit f5e2f48
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
url = https://github.com/AsteroidOS/libasteroid
[submodule "asteroidsyncserviced/libwatchfish"]
path = asteroidsyncserviced/libwatchfish
url = https://git.javispedro.com/libwatchfish.git
url = git@github.com:piggz/libwatchfish.git
2 changes: 1 addition & 1 deletion asteroidsyncservice/asteroidsyncservice.pro
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ uri = org.asteroid.syncservice

contains(CONFIG, telescope) {
include(telescope.pri)
}
}

contains(CONFIG, starfish) {
include(starfish.pri)
Expand Down
2 changes: 1 addition & 1 deletion asteroidsyncservice/platforms/sailfishos/servicecontrol.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include <QDBusInterface>
#include <QObject>

static const QString SYNCSERVICED_SYSTEMD_UNIT("asteroidsyncserviced.service");
static const QString SYNCSERVICED_SYSTEMD_UNIT("harbour-asteroidsyncserviced.service");

class ServiceControl : public QObject
{
Expand Down
8 changes: 7 additions & 1 deletion asteroidsyncserviced/asteroidsyncserviced.pro
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ QT -= gui
include(../version.pri)
include(libasteroid/libasteroid.pri)

TARGET = asteroidsyncserviced
contains(CONFIG, telescope) {
TARGET = asteroidsyncserviced
}

contains(CONFIG, starfish) {
TARGET = harbour-asteroidsyncserviced
}

CONFIG += c++11
CONFIG += console
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Requires=dbus.socket bluetooth.target booster-qt5.service
After=pre-user-session.target lipstick.service dbus.socket bluetooth.target booster-qt5.service

[Service]
ExecStart=/usr/bin/invoker -o --type=qt5 /usr/bin/asteroidsyncserviced
ExecStart=/usr/bin/invoker -o --type=qt5 /usr/bin/harbour-asteroidsyncserviced
Restart=always

[Install]
Expand Down
5 changes: 4 additions & 1 deletion asteroidsyncserviced/starfish.pri
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ DEFINES += SAILFISHOS_PLATFORM

WATCHFISH_FEATURES = notificationmonitor walltime music

SUBDIRS += libwatchfish
include(libwatchfish/libwatchfish.pri)

PKGCONFIG += qt5-boostable

SOURCES += platforms/sailfishos/sailfishplatform.cpp

HEADERS += platforms/sailfishos/sailfishplatform.h

DISTFILES += \
$$PWD/harbour-asteroidsyncserviced.service

0 comments on commit f5e2f48

Please sign in to comment.