Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change patch to json and fix readme #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change patch to json and fix readme #12

wants to merge 1 commit into from

Conversation

prabushyam
Copy link
Contributor

mcieplak
mcieplak reviewed Jan 16, 2020
View reviewed changes
README.md

```
kubectl patch deploy <app.yaml> -p k8s-athenz-identity/k8s/patch/sia.yaml
kubectl patch deploy <app.yaml> -p "$(k8s/patch/sia.json)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command is also not working, I believe you need to remove the word deploy and add -f and also the "$(k8s/patch/sia.json)" is not a command?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work:
kubectl patch -f app.yaml -p "$(cat k8s/patch/sia.json)"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command actually also works with the yaml format as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed it is working with yaml as well.

@mcieplak
Copy link
Contributor

mcieplak commented Jul 2, 2020

Hi @prabushyam
If you update the readme with the following command it should be enough to work with the existing yaml:

kubectl patch -f app.yaml -p "$(cat k8s/patch/sia.yaml)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcieplak mcieplak mcieplak left review comments

@kevindiu kevindiu kevindiu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prabushyam @mcieplak @kevindiu