Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for windows #45

Merged
merged 6 commits into from
Aug 19, 2021
Merged

Fixes for windows #45

merged 6 commits into from
Aug 19, 2021

Conversation

pecheny
Copy link
Contributor

@pecheny pecheny commented Aug 18, 2021

#44 related. As for building on windows, I have following results:

  1. Sample project builds and runs fine (hl target) with batch scripts. Call under vcvars and make sure %HLPATH% is set and point to folder with hl. (1.10 in my case it's last 32 bit release).
  2. Test launcher for windows (test-windows.bat ) do what it should – builds and calls tests.
    2.1 test under hl fails with
    src\module.c(465) : FATAL ERROR : Invalid signature for function ammer_native@w__ammer_externs_AmmerArray_0_AmmerArray_0_ofNativeInt : POBi__Xwt_array_0_0_ required but POiBi__Xwt_array_0_0_ found in hdll
    2.2 Linking cpp test fails with
    native.obj : error LNK2019: unresolved external symbol _utf8_decode referenced in function _rev_string
    But if body of rev_string() in native.c is commented out then 171 out of 173 assertion is succeeded.
    2.3 Test on eval fails with exception Ammer.hx:572: characters 13-18 : Uncaught exception !
  3. the PR is also contains fix for MSVC compiler flags.

@Aurel300 Aurel300 merged commit 9fe359b into Aurel300:master Aug 19, 2021
@Aurel300
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants