Refactor how we derive shown_products & not_shown_products.

projects/packages/my-jetpack/src/class-initializer.php

@@ -819,7 +819,7 @@ public static function get_paid_plans_plugins_requirements() {
 		$plugin_requirements = array();
 		foreach ( Products::get_products_classes() as $slug => $product_class ) {
 			// Skip these- we don't show them in My Jetpack.
-			if ( in_array( $slug, Products::$not_shown_products, true ) ) {
+			if ( in_array( $slug, Products::get_not_shown_products(), true ) ) {
 				continue;
 			}
 			if ( ! $product_class::has_paid_plan_for_product() ) {
@@ -1028,7 +1028,7 @@ public static function alert_if_paid_plan_expiring( array $red_bubble_slugs ) {
 		$products_included_in_expiring_plan = array();
 		foreach ( $product_classes as $key => $product ) {
 			// Skip these- we don't show them in My Jetpack.
-			if ( in_array( $key, Products::$not_shown_products, true ) ) {
+			if ( in_array( $key, Products::get_not_shown_products(), true ) ) {
 				continue;
 			}
 

projects/packages/my-jetpack/src/class-products.php

@@ -115,24 +115,6 @@ class Products {
 		self::STATUS_NEEDS_ATTENTION__ERROR,
 	);
 
-	/**
-	 * List of product slugs that are Not displayed on the main My Jetpack page
-	 *
-	 * @var array
-	 */
-	public static $not_shown_products = array(
-		'creator',
-		'extras',
-		'ai', // 'ai' is a duplicate class of 'jetpack-ai', and therefore not needed.
-		'scan',
-		'security',
-		'growth',
-		'complete',
-		'newsletter',
-		'site-accelerator',
-		'related-posts',
-	);
-
 	/**
 	 * Get the list of Products classes
 	 *
@@ -194,6 +176,33 @@ public static function get_products_classes() {
 		return $final_classes;
 	}
 
+	/**
+	 * List of product slugs that are displayed on the main My Jetpack page
+	 *
+	 * @var array
+	 */
+	public static $shown_products = array(
+		'anti-spam',
+		'backup',
+		'boost',
+		'crm',
+		'jetpack-ai',
+		'search',
+		'social',
+		'protect',
+		'videopress',
+		'stats',
+	);
+
+	/**
+	 * Gets the list of product slugs that are Not displayed on the main My Jetpack page
+	 *
+	 * @return array
+	 */
+	public static function get_not_shown_products() {
+		return array_diff( array_keys( static::get_products_classes() ), self::$shown_products );
+	}
+
 	/**
 	 * Product data
 	 *