phan-plugins: Work around microsoft/tolerant-php-parser not being 8.4…

…-safe yet
Automattic · Nov 19, 2024 · 7777ebc · 7777ebc
1 parent 2ee17ff
commit 7777ebc
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/projects/packages/phan-plugins/changelog/add-ci-php-8.4 b/projects/packages/phan-plugins/changelog/add-ci-php-8.4
@@ -0,0 +1,5 @@
+Significance: patch
+Type: fixed
+Comment: Work around microsoft/tolerant-php-parser not being 8.4-safe yet in test
+
+
diff --git a/projects/packages/phan-plugins/tests/php/IntegrationTest.php b/projects/packages/phan-plugins/tests/php/IntegrationTest.php
@@ -101,12 +101,22 @@ private function runPhan( $dir, $usePolyfill = false, $analyzeTwice = false ) {
 		$printer = new CapturingJSONPrinter();
 		Phan::setPrinter( $printer );
 
-		Phan::analyzeFileList(
-			$this->codeBase,
-			static function () use ( $cli ) {
-				return $cli->getFileList();
+		$old = error_reporting();
+		try {
+			if ( $usePolyfill ) {
+				// microsoft/tolerant-php-parser raises PHP 8.4 deprecation warnings.
+				// @todo If it gets updated at some point, hopefully this can be removed.
+				error_reporting( $old & ~E_DEPRECATED );
 			}
-		);
+			Phan::analyzeFileList(
+				$this->codeBase,
+				static function () use ( $cli ) {
+					return $cli->getFileList();
+				}
+			);
+		} finally {
+			error_reporting( $old );
+		}
 
 		$expectFile = $this->chooseFile( "$dir/expect.json", $usePolyfill, $analyzeTwice );
 		$expect     = json_decode( file_get_contents( $expectFile ), true );