-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: Update e2e tests to account for lazy loading removal #33833
Conversation
Jetpack removed lazy loading, so these tests have been trimmed down because of that. Since our module is disabled by default and can not be activated, it shouldn't be activatable.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into it. I think we should not have any lazy loading tests since currently it depend on too many variables like WP 6.4, Gutenberg 16.6.0. I think it will just add to the current flakyness of the tests.
projects/plugins/boost/tests/e2e/specs/base/jetpack-compatibility.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this. Looks like we may need add more tests since we have added new features in Boost.
Jetpack removed lazy loading, so these tests have been trimmed down
because of that.
Since our module is disabled by default and can not be activated,
it shouldn't be activatable.
Proposed changes:
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
no
Testing instructions: