Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Update e2e tests to account for lazy loading removal #33833

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

dilirity
Copy link
Member

Jetpack removed lazy loading, so these tests have been trimmed down
because of that.
Since our module is disabled by default and can not be activated,
it shouldn't be activatable.

Proposed changes:

  • Fixes e2e tests related to recent lazy loading updates. Since the module is now visible in the UI but can not be activated, the tests now accommodate for that.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Checkout this version of Boost;
  • Run e2e tests - they should all pass (hopefully no tunnel issues).

Jetpack removed lazy loading, so these tests have been trimmed down
because of that.
Since our module is disabled by default and can not be activated,
it shouldn't be activatable.
@dilirity dilirity added [Status] Needs Team Review E2E Tests [Plugin] Boost A feature to speed up the site and improve performance. labels Oct 27, 2023
@dilirity dilirity requested a review from a team October 27, 2023 11:02
@dilirity dilirity self-assigned this Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Boost plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@dilirity dilirity marked this pull request as draft October 27, 2023 11:39
@dilirity dilirity removed the request for review from a team October 27, 2023 11:39
@dilirity dilirity requested a review from a team October 30, 2023 07:48
@dilirity dilirity marked this pull request as ready for review October 30, 2023 07:48
Copy link
Contributor

@haqadn haqadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into it. I think we should not have any lazy loading tests since currently it depend on too many variables like WP 6.4, Gutenberg 16.6.0. I think it will just add to the current flakyness of the tests.

@dilirity dilirity changed the title Boost: Update lazy loading e2e tests to account for lazy loading disable Boost: Update e2e tests to account for lazy loading removal Oct 31, 2023
@dilirity dilirity requested a review from haqadn November 2, 2023 08:37
@anomiex anomiex mentioned this pull request Nov 2, 2023
3 tasks
Copy link
Contributor

@haqadn haqadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this. Looks like we may need add more tests since we have added new features in Boost.

@dilirity dilirity merged commit 2aebc8f into trunk Nov 3, 2023
52 checks passed
@dilirity dilirity deleted the update/boost/e2e-tests-lazy-loading branch November 3, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Tests [Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants