Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Add tests for Image CDN #36694

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented Apr 2, 2024

Part of #33877

Proposed changes:

  • Add e2e tests for the Image CDN module:
    • Upgrade section isn't visible while the module is inactive;
    • Image isn't loaded via CDN while the module is inactive;
    • Upgrade section is visible while the module is active;
    • Image is loaded via CDN when module is active.
  • Update Boost CLI to support activating/deactivating Image CDN;
  • Update docker e2e test matrix to include tests (you can check the GH actions section to see the tests).

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Run tests to see if everything is working as expected.

@dilirity dilirity added Docker [Status] Needs Team Review E2E Tests [Plugin] Boost A feature to speed up the site and improve performance. labels Apr 2, 2024
@dilirity dilirity requested a review from a team April 2, 2024 12:38
@dilirity dilirity self-assigned this Apr 2, 2024
@github-actions github-actions bot added [Tests] Includes Tests Actions GitHub actions used to automate some of the work around releases and repository management labels Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Boost plugin:

  • Next scheduled release: May 7, 2024.
  • Scheduled code freeze: April 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

haqadn
haqadn previously approved these changes Apr 3, 2024
Copy link
Contributor

@haqadn haqadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏼

@dilirity
Copy link
Member Author

dilirity commented Apr 3, 2024

@haqadn this needs a review, since I merged it with trunk after #36716 got merged.

@dilirity dilirity requested a review from haqadn April 3, 2024 13:24
Copy link
Contributor

@haqadn haqadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@dilirity dilirity merged commit a3e579b into trunk Apr 4, 2024
58 of 59 checks passed
@dilirity dilirity deleted the add/boost/e2e-tests-image-cdn branch April 4, 2024 09:10
TimBroddin pushed a commit that referenced this pull request Apr 10, 2024
* Add tests for Image CDN

* Add Boost's image cdn test configuration to e2e test matrix

* add changelog

* Remove e2e helper plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management Docker E2E Tests [Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants