renovate: Fix warnings from weird wpcomsh deps #37885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
For the five
type: vcs
deps, Renovate needs aname
key in each one so it knows the package name (versus Composer itself that fetches the composer.json).The "wordpress/classic-editor-plugin" fake package is a bit more difficult. We have to disable the 'packagist' entry entirely. But then we can make a customManager and customDatasource for it. 😀
Other information:
Jetpack product discussion
None
Does this pull request change what data or activity we track or use?
No
Testing instructions:
If you look at our current Renovate dashboard and recent renovate PRs like #37860, you'll see warnings like
Warning
Renovate failed to look up the following dependencies:
Failed to look up packagist package automattic/at-pressable-podcasting
,Failed to look up packagist package automattic/custom-fonts
,Failed to look up packagist package automattic/custom-fonts-typekit
,Failed to look up packagist package automattic/text-media-widget-styles
,Failed to look up packagist package automattic/wc-calypso-bridge
,Failed to look up packagist package wordpress/classic-editor-plugin
.Files affected:
projects/plugins/wpcomsh/composer.json
and
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Cherry-pick this into a fork, set up the secrets so you can run the Renovate action there, and do so. Those should go away.