Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: Fix warnings from weird wpcomsh deps #37885

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jun 14, 2024

Proposed changes:

For the five type: vcs deps, Renovate needs a name key in each one so it knows the package name (versus Composer itself that fetches the composer.json).

The "wordpress/classic-editor-plugin" fake package is a bit more difficult. We have to disable the 'packagist' entry entirely. But then we can make a customManager and customDatasource for it. 😀

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

If you look at our current Renovate dashboard and recent renovate PRs like #37860, you'll see warnings like

Warning

Renovate failed to look up the following dependencies: Failed to look up packagist package automattic/at-pressable-podcasting, Failed to look up packagist package automattic/custom-fonts, Failed to look up packagist package automattic/custom-fonts-typekit, Failed to look up packagist package automattic/text-media-widget-styles, Failed to look up packagist package automattic/wc-calypso-bridge, Failed to look up packagist package wordpress/classic-editor-plugin.

Files affected: projects/plugins/wpcomsh/composer.json

and

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Cherry-pick this into a fork, set up the secrets so you can run the Renovate action there, and do so. Those should go away.

For the five `type: vcs` deps, Renovate needs a `name` key in each one
so it knows the package name (versus Composer itself that fetches the
composer.json).

The "wordpress/classic-editor-plugin" fake package is a bit more
difficult. We have to disable the 'packagist' entry entirely. But then
we can make a customManager and customDatasource for it. 😀
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Jun 14, 2024
@anomiex anomiex requested a review from a team June 14, 2024 16:43
@anomiex anomiex self-assigned this Jun 14, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Wpcomsh plugin:

  • Next scheduled release: July 2, 2024.
  • Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

zinigor
zinigor previously approved these changes Jun 17, 2024
@zinigor zinigor enabled auto-merge (squash) June 17, 2024 12:32
@zinigor zinigor merged commit 149908d into trunk Jun 17, 2024
53 checks passed
@zinigor zinigor deleted the fix/renovate-and-wpcomsh-weird-deps branch June 17, 2024 13:03
@github-actions github-actions bot added this to the wpcomsh/3.22.6 milestone Jun 17, 2024
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Wpcomsh [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants