-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MU WPCOM: Port the newspack blocks from the ETK (2nd try) #38724
Conversation
This reverts commit 75c5264.
b77013d
to
8eacb47
Compare
8eacb47
to
6039568
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, see the conversation in p1722993219555279-slack-CRWCHQGUB for a more in-depth review.
); | ||
|
||
add_action( | ||
is_admin() ? 'enqueue_block_assets' : 'enqueue_block_editor_assets', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add these conditions? It should always be enqueue_block_editor_assets
for block scripts that register the blocks. See #41055.
Related to p1722871269505439-slack-CRWCHQGUB
Proposed changes:
load_etk_features_flags
function & Load the newspack blocks feature only when theNewspack_Blocks
isn't declared- 2803837Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: