Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: Add packageManager field for corepack compatibility #40201

Merged
merged 4 commits into from
Nov 15, 2024
Merged

package.json: Add packageManager field for corepack compatibility #40201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01e09d2
package.json: Add packageManager field for corepack compatibility
mreishus Nov 14, 2024
4c314a7
change to 9.3.0 to align with github actions
mreishus Nov 14, 2024
dedfb82
add manage-package-manager-versions=false
mreishus Nov 15, 2024
57d66fc
Add structure linting check
anomiex Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/files/lint-project-structure.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,11 @@ if ! pnpm semver --range "$RANGE" "$PNPM_VERSION" &>/dev/null; then
LINE=$(jq --stream 'if length == 1 then .[0][:-1] else .[0] end | if . == ["engines","pnpm"] then input_line_number - 1 else empty end' package.json)
echo "::error file=package.json,line=$LINE::Pnpm version $PNPM_VERSION in .github/versions.sh does not satisfy requirement $RANGE from package.json"
fi
if ! jq -e --arg v "pnpm@$PNPM_VERSION" '.packageManager == $v' package.json &>/dev/null; then
EXIT=1
LINE=$(jq --stream 'if length == 1 then .[0][:-1] else .[0] end | if . == ["packageManager"] then input_line_number - 1 else empty end' package.json)
echo "::error file=package.json,line=$LINE::Version in package.json packageManager must be \"pnpm@$PNPM_VERSION\", to match .github/versions.sh."
fi

# - Check for incorrect next-version tokens.
debug "Checking for incorrect next-version tokens."
Expand Down
2 changes: 2 additions & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ resolution-mode = highest

# @automattic/jetpack-webpack-config looks for this.
jetpack-webpack-config-resolve-conditions=jetpack:src

manage-package-manager-versions=false
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,6 @@
"engines": {
"node": "^22.9.0",
"pnpm": "^9.3.0 <9.12.0"
}
},
"packageManager": "[email protected]"
}
Loading