-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms: fix sidebar spacing #41133
Forms: fix sidebar spacing #41133
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
@simison I looked into why we were not picking up the default styles it turned out it was because for some reason we were adding an empty div to the controls. Which made the styles behave not as expected. I fixed it an the styles are more what we would expect them to be. Feel free to merge the PR if you agree with the way forward :) |
Nice! It looks good. If this works well feel free to merge, otherwise I'll do more testing tomorrow and deploy. |
e5778e4
to
5339dde
Compare
* Forms: fix spacing in sidebar * changelog * Fixes the form so that we ship less code but still end up with the same result * Add key to the Select control --------- Co-authored-by: Enej Bajgoric <[email protected]>
Fixes #41124
Proposed changes:
Before
After
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: