New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Code Documentation Clarity and Fix Typos #72

Open

savvar9991 wants to merge 1 commit into AztecProtocol:avm from savvar9991:correct

savvar9991 commented Dec 21, 2024

Line 4: Changed spelling

Most if this is heavily inspired by zkASM / PIL of the polygon/hermez team.

Most of this is heavily inspired by zkASM / PIL of the polygon/hermez team.

Fixed typo: "if" -> "of"

Line 28: Changed terminology

This could also help to combine two lookps into one.

This could also help to combine two lookups into one.

Fixed typo: "lookps" -> "lookups"

Line 62: Improved clarity

because onyl one value of 'C' is valid for each '0'-'A'-'B'-combination.

because only one value of 'C' is valid for each '0'-'A'-'B'-combination.

Fixed typo: "onyl" -> "only"

Line 106: Fixed terminology

Similarly, in (2), users should also show when the combintation of lookups have

Similarly, in (2), users should also show when the combination of lookups have

Fixed typo: "combintation" -> "combination"

Line 152: Improved clarity and grammar

(be it because the are just duplicated or because they are already implied by lookups).

(be it because they are just duplicated or because they are already implied by lookups).

Fixed grammar: "the" -> "they"


          Update IDEAS.md

3f3a752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet