-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Generate embeddings for images #892
Conversation
Co-authored-by: Adam Dougal <[email protected]>
Co-authored-by: Adam Dougal <[email protected]>
Coverage Report •
|
code/backend/batch/utilities/helpers/azure_computer_vision_client.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.. some comments
code/backend/batch/utilities/helpers/azure_computer_vision_client.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Nothing major, some minor ones. Ship-It.
______________________________________________
.-' _ '.
.' |-' |
.' | |
_.' p _\_/_ p |
_.' | .' | '. | |
__..' | / | \ | |
___..' .T\ ======+====== /T. |
;;;\:::: .' | \ / | \ / | '. |
;;;|:::: .' | \/ | \/ | '. |
;;;/:::: .' | \ | \ | '. |
''.__ .' | \ | \ | '. |
''._ <_________|_____>_____|__________>|_________> |
'._ (___________|___________|___________|___________) |
'. \;;;o;;;;o;;;;;o;;;;;o;;;;;o;;;;;o;;;;;o;;;;/ |
'.~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ |
'. ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ |
'-.______________________________________________.'
tests are failing.. looking into them |
fixed. |
Regarding the use of a mock http server for unit tests: I understand the point about not wanting to tie our mocks tightly to the underlying implementation (http requests vs sdk), but couldn't we resolve this issue by just using an interface and implementation? Mock the interface behavior in the tests, and the implementation details will remain hidden. I would vote for keeping unit tests free of http servers - and reserve this type of testing for our functional tests. Consistency helps readers reason about the code base. I'd argue that in this case readability is more important than the possible rework of the test mocks if/when we switch the underlying calls from http to sdk. |
Bhavana and I caught up on a call. Decided to keep the tests as they are, but added a comment to the test class explaining the rationale. |
Co-authored-by: Adam Dougal <[email protected]> Co-authored-by: Adam Dougal <[email protected]> Co-authored-by: Arpit Gaur <[email protected]>
Required by #748
Purpose
conftest.py
, so they are in the scope of all tests (unit + functional)Does this introduce a breaking change?
Testing: