Deploy.sh will have the option to choose deployment type #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) dev 2) Dev and Stage 3) Dev, Stage and Prod Common.sh will heold the function for this changes envtemplate the new environmnent variable for the deployment options deploy_azdo_pipelines.sh will deploy the release pipeline if option 2 or 3 are choosen which implies the deploy of t least 2 environmnents
There was a problem hiding this comment.
Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (4)
- e2e_samples/parking_sensors/.devcontainer/.envtemplate: Language not supported
- e2e_samples/parking_sensors/deploy.sh: Language not supported
- e2e_samples/parking_sensors/scripts/common.sh: Language not supported
- e2e_samples/parking_sensors/scripts/deploy_azdo_pipelines.sh: Language not supported
Comments suppressed due to low confidence (2)
e2e_samples/parking_sensors/README.md:7
- The word 'heold' should be 'hold'.
Common.sh will heold the function for this changes
e2e_samples/parking_sensors/README.md:11
- The word 'ould' should be 'could'.
Yes. The deploy ould break
LiliamLeme
changed the title
**Workaround - Manually Deleting Federated Credentials:**
There was a problem hiding this comment.
Copilot reviewed 1 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- e2e_samples/parking_sensors/.devcontainer/.envtemplate: Language not supported
- e2e_samples/parking_sensors/deploy.sh: Language not supported
- e2e_samples/parking_sensors/scripts/common.sh: Language not supported
- e2e_samples/parking_sensors/scripts/deploy_azdo_pipelines.sh: Language not supported
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (4)
- e2e_samples/parking_sensors/.devcontainer/.envtemplate: Language not supported
- e2e_samples/parking_sensors/deploy.sh: Language not supported
- e2e_samples/parking_sensors/scripts/common.sh: Language not supported
- e2e_samples/parking_sensors/scripts/deploy_azdo_pipelines.sh: Language not supported
Comments suppressed due to low confidence (1)
e2e_samples/parking_sensors/README.md:310
- The phrase 'During deployment, you will be presented with three options' is repeated. It should be removed from line 310 to avoid redundancy.
During deployment, you will be presented with three options. Note that deployments are standalone and cannot be used as incremental deployments:
fixing copilot fix
bsherwin
requested changes
Jan 21, 2025
the enviromnent variable Initialize env variable in the init_environment
There was a problem hiding this comment.
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (5)
- e2e_samples/parking_sensors/.devcontainer/.envtemplate: Language not supported
- e2e_samples/parking_sensors/deploy.sh: Language not supported
- e2e_samples/parking_sensors/scripts/common.sh: Language not supported
- e2e_samples/parking_sensors/scripts/deploy_azdo_pipelines.sh: Language not supported
- e2e_samples/parking_sensors/scripts/init_environment.sh: Language not supported
ydaponte
requested changes
Jan 24, 2025
Adjusting explanations about env variable in the readme and envtemplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code and Documentation changes to make it user to choose the environment to deploy.
Type of PR
Code, DocumentationPurpose
Deploy.sh will have the option to deploy as:
Common.sh will hold the function for this changes
envtemplate the new environment variable for the deployment options
deploy_azdo_pipelines.sh will deploy the release pipeline if option 2 or 3 are chosen which implies the deploy of At least 2 environments.
...
Does this introduce a breaking change? If yes, details on what can break. Yes. The deploy could break
Author pre-publish checklist
Validation steps
Issues Closed or Referenced