Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keyvault integration to Variable Groups. Add service connection creation #1053

Open
wants to merge 6 commits into
base: kitsune/ci_pipelines_
Choose a base branch
from

Conversation

devlace
Copy link
Contributor

@devlace devlace commented Jan 22, 2025

Type of PR

  • Code changes

Purpose

  • Creates a service connection per environment. Utilizes service principal already provided.
  • Create a second Variable Group with KeyVault integration. Currently you cannot have a variable group with "mixed" variables (variables from keyvault and manually set variable), so a second variable group is needed for variables from Keyvault.

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • Deploy sample as per instruction. Check if service connections are created. Check if variable groups are created with KeyVault integration

Issues Closed or Referenced

@devlace devlace changed the base branch from feat/e2e-fabric-dataops-sample-v0-2 to kitsune/ci_pipelines_ January 22, 2025 00:46
@promisinganuj promisinganuj self-assigned this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants