Fix broken controller API (#2126)

Addresses #2124
Azure · Nov 30, 2023 · 7e18bc4 · 7e18bc4
1 parent d4c8bb0
commit 7e18bc4
Show file tree

Hide file tree

Showing 23 changed files with 505 additions and 172 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -479,6 +479,9 @@ dotnet_diagnostic.CA1812.severity = silent
 # CA1003: Use generic event handler instances
 dotnet_diagnostic.CA1003.severity = silent
 
+# CA1008: Enums should have zero value
+dotnet_diagnostic.CA1008.severity = silent
+
 [*.{cs,vb}]
 dotnet_style_coalesce_expression = true:suggestion
 dotnet_style_null_propagation = true:suggestion
@@ -505,4 +508,8 @@ dotnet_diagnostic.CA5371.severity = suggestion
 dotnet_diagnostic.CA5370.severity = suggestion
 dotnet_diagnostic.CA5372.severity = suggestion
 dotnet_diagnostic.CA5374.severity = warning
-dotnet_diagnostic.CA2251.severity = suggestion
+dotnet_diagnostic.CA2251.severity = suggestion
+dotnet_style_prefer_collection_expression = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
+dotnet_style_prefer_conditional_expression_over_assignment = true:silent
diff --git a/docs/opc-publisher/api.md b/docs/opc-publisher/api.md
diff --git a/docs/opc-publisher/definitions.md b/docs/opc-publisher/definitions.md
@@ -1285,7 +1285,7 @@ Constants defined for the ValueRank attribute.
 ### OpcAuthenticationMode
 Enum that defines the authentication method
 
-*Type* : enum (Anonymous, UsernamePassword)
+*Type* : enum (Anonymous, UsernamePassword, Certificate)
 
 
 <a name="opcnodemodel"></a>
@@ -1593,6 +1593,7 @@ Contains the nodes which should be published
 |**UseReverseConnect**  <br>*optional*|Use reverse connect to connect ot the endpoint|boolean|
 |**UseSecurity**  <br>*optional*|Secure transport should be used to connect to<br>the opc server.|boolean|
 |**Version**  <br>*optional*|Version number of the entry|integer (int32)|
+|**WriterGroupQualityOfService**  <br>*optional*||[QoS](definitions.md#qos)|
 |**WriterGroupTransport**  <br>*optional*||[WriterGroupTransport](definitions.md#writergrouptransport)|
 
 
@@ -1603,6 +1604,11 @@ PublishNodes direct method response
 *Type* : object
 
 
+<a name="qos"></a>
+### QoS
+*Type* : enum (AtMostOnce, AtLeastOnce, ExactlyOnce)
+
+
 <a name="querycompilationrequestmodel"></a>
 ### QueryCompilationRequestModel
 Query compiler request model
@@ -2361,7 +2367,7 @@ Certificate chain
 |Name|Description|Schema|
 |---|---|---|
 |**chain**  <br>*optional*|Chain|< [X509CertificateModel](definitions.md#x509certificatemodel) > array|
-|**status**  <br>*optional*|Chain validation status if validated|enum (NoError, NotTimeValid, Revoked, NotSignatureValid, NotValidForUsage, UntrustedRoot, RevocationStatusUnknown, Cyclic, InvalidExtension, InvalidPolicyConstraints, InvalidBasicConstraints, InvalidNameConstraints, HasNotSupportedNameConstraint, HasNotDefinedNameConstraint, HasNotPermittedNameConstraint, HasExcludedNameConstraint, PartialChain, CtlNotTimeValid, CtlNotSignatureValid, CtlNotValidForUsage, HasWeakSignature, OfflineRevocation, NoIssuanceChainPolicy, ExplicitDistrust, HasNotSupportedCriticalExtension)|
+|**status**  <br>*optional*|Chain validation status if validated|enum (NotTimeValid, Revoked, NotSignatureValid, NotValidForUsage, UntrustedRoot, RevocationStatusUnknown, Cyclic, InvalidExtension, InvalidPolicyConstraints, InvalidBasicConstraints, InvalidNameConstraints, HasNotSupportedNameConstraint, HasNotDefinedNameConstraint, HasNotPermittedNameConstraint, HasExcludedNameConstraint, PartialChain, CtlNotTimeValid, CtlNotSignatureValid, CtlNotValidForUsage, HasWeakSignature, OfflineRevocation, NoIssuanceChainPolicy, ExplicitDistrust, HasNotSupportedCriticalExtension)|
 
 
 <a name="x509certificatemodel"></a>
@@ -2385,7 +2391,7 @@ Certificate model
 ### X509ChainStatus
 Status of x509 chain
 
-*Type* : enum (NoError, NotTimeValid, Revoked, NotSignatureValid, NotValidForUsage, UntrustedRoot, RevocationStatusUnknown, Cyclic, InvalidExtension, InvalidPolicyConstraints, InvalidBasicConstraints, InvalidNameConstraints, HasNotSupportedNameConstraint, HasNotDefinedNameConstraint, HasNotPermittedNameConstraint, HasExcludedNameConstraint, PartialChain, CtlNotTimeValid, CtlNotSignatureValid, CtlNotValidForUsage, HasWeakSignature, OfflineRevocation, NoIssuanceChainPolicy, ExplicitDistrust, HasNotSupportedCriticalExtension)
+*Type* : enum (NotTimeValid, Revoked, NotSignatureValid, NotValidForUsage, UntrustedRoot, RevocationStatusUnknown, Cyclic, InvalidExtension, InvalidPolicyConstraints, InvalidBasicConstraints, InvalidNameConstraints, HasNotSupportedNameConstraint, HasNotDefinedNameConstraint, HasNotPermittedNameConstraint, HasExcludedNameConstraint, PartialChain, CtlNotTimeValid, CtlNotSignatureValid, CtlNotValidForUsage, HasWeakSignature, OfflineRevocation, NoIssuanceChainPolicy, ExplicitDistrust, HasNotSupportedCriticalExtension)